chore(deps): update dependency google-auth to v2.49.0#846
chore(deps): update dependency google-auth to v2.49.0#846renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the google-auth dependency from version 2.41.1 to 2.49.0. While the update is beneficial, it appears to have been applied in a way that leaves the requirements.txt file in an inconsistent state. Specifically, google-auth version 2.47.0 and later no longer depend on cachetools, but cachetools has not been removed from requirements.txt. I've left a comment suggesting to regenerate the file using pip-compile to ensure all dependencies are correctly resolved.
Note: Security Review has been skipped due to the limited scope of the PR.
| google-auth==2.49.0 \ | ||
| --hash=sha256:9cc2d9259d3700d7a257681f81052db6737495a1a46b610597f4b8bafe5286ae \ | ||
| --hash=sha256:f893ef7307f19cf53700b7e2f61b5a6affe3aa0edf9943b13788920ab92d8d87 |
There was a problem hiding this comment.
While updating google-auth is a good step, this change appears to have been made in a way that leaves the requirements.txt file in an inconsistent state. According to the release notes for google-auth v2.47.0, the dependency on cachetools was removed. However, cachetools is still present in this file (lines 17-20), with a comment indicating it's required by google-auth.
To ensure dependency consistency and remove potentially unnecessary packages, please regenerate this file by running pip-compile --generate-hashes. This will correctly resolve all dependencies and remove cachetools if it's no longer needed by any other package.
This PR contains the following updates:
==2.41.1→==2.49.0Release Notes
googleapis/google-auth-library-python (google-auth)
v2.48.0Compare Source
Features
NO_GCE_CHECKenvironment variable (#1610) (383c9827536d9376e8248370ce4c2b83e468d027)Bug Fixes
content-headerfrom AWS IMDS get request (#1934) (97bfea9e02ede953fc8ee154e0deed3a3cfc6dcc)user_verification=preferredfor ReAuth WebAuthn challenge (#1798) (3f88a24089c4ee6822d510de0db210b54260d873)v2.47.0Compare Source
Features
cachetoolsdependency in favor of simple local implementation (#1590) (5c07e1c4f52bc77a1b16fa3b7b3c5269c242f6f4)Bug Fixes
v2.46.0Compare Source
Documentation
Features
Bug Fixes
v2.45.0Compare Source
Features
v2.44.0Compare Source
Features
Bug Fixes
v2.43.0Compare Source
Features
GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the MWID/X.509 cert
sources detected. Also, fix check_use_client_cert to return boolean
value.
Change #1848 added the check_use_client_cert method that helps know if
client cert should be used for mTLS connection. However, that was in a
private class, thus, created a public wrapper of the same function so
that it can be used by python Client Libraries. Also, updated
check_use_client_cert to return a boolean value instead of existing
string value for better readability and future scope.
--------- (1535eccbff0ad8f3fd6a9775316ac8b77dca66ba)
(either true or false), the SDK will respect that setting. This is
necessary for test scenarios and users who need to explicitly control
mTLS behavior.
set, the SDK will automatically enable mTLS only if it detects Managed
Workload Identity (MWID) or X.509 Workforce Identity Federation (WIF)
certificate sources. In other cases where the variable is not set, mTLS
will remain disabled.
** This change also adds the helper method
check_use_client_certandit's unit test, which will be used for checking the criteria for setting
the mTLS to true
** This change is only for Auth-Library, other changes will be created
for Client-Library use-cases.
--------- (395e405b64b56ddb82ee639958c2e8056ad2e82b)
google-authto librarian (#1838) This PR onboardsgoogle-authlibrary to the Librarian system.Wait for
#1819. (c503eaa511357d7a76cc1e1f1d3a3be2dabd5bca)
v2.42.1Compare Source
Bug Fixes
v2.42.0Compare Source
Features
Bug Fixes
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.