chore: librarian update image pull request: 20251216T114756Z#1465
chore: librarian update image pull request: 20251216T114756Z#1465daniel-sanche wants to merge 1 commit intomainfrom
Conversation
…prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Docker image utilized by the internal librarian tool, which automates the generation of client libraries. Following this update, the tool encountered an issue specifically with the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, triggered by a librarian image update, has resulted in a critical issue. The code generation for the google-cloud-spanner library has failed, leading to the removal of all its source files. Merging this PR in its current state would break the google-cloud-spanner client library. This change should be reverted or the generation failure must be fixed before this can be merged.
| @@ -1,4 +1,4 @@ | |||
| image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91 | |||
| image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209 | |||
There was a problem hiding this comment.
This update to the generator image has caused a build failure for the google-cloud-spanner library, as noted in the pull request description. Consequently, all source files for this library have been removed in this PR. Merging this change would break the google-cloud-spanner client. This is a critical issue that must be addressed by fixing the generation failure before this PR can be merged.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
Generation failed for