fix(schema): add missing config properties accepted by code#2765
Open
chad-loder wants to merge 1 commit into
Open
fix(schema): add missing config properties accepted by code#2765chad-loder wants to merge 1 commit into
chad-loder wants to merge 1 commit into
Conversation
The config JSON schema is missing several properties that `ReleaserConfigJson` and `ReleaserPackageConfig` accept at runtime: - `include-commit-authors` (boolean) — changelog author attribution - `component` (string) — per-package component name - `package-name` (string) — per-package distribution name - `skip-snapshot` (boolean, Java-only) — suppress snapshot PRs Adds all four to `ReleaserConfigOptions` (shared definition) and to the top-level `properties` allowlist. Purely additive — no existing properties are modified, narrowed, or removed. Fixes googleapis#2518
185b61a to
56f8fdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2518 🦕
The config JSON schema (
schemas/config.json) is missing severalproperties that the TypeScript types in
src/manifest.tsaccept atruntime. This causes false-positive validation errors for users who
validate their config against the published schema.
Added properties
include-commit-authorsbooleanReleaserConfigJsonL183componentstringReleaserPackageConfigL227package-namestringReleaserPackageConfigL226skip-snapshotbooleanReleaserConfigJsonL193All four are added to the
ReleaserConfigOptionsdefinition and tothe top-level
propertiesallowlist. Purely additive — no existingproperties are modified, narrowed, or removed.
Repro (before this fix)