fix(go): support semver prerelease suffixes in version-go regex#2803
Open
noahdietz wants to merge 1 commit into
Open
fix(go): support semver prerelease suffixes in version-go regex#2803noahdietz wants to merge 1 commit into
noahdietz wants to merge 1 commit into
Conversation
Author
|
Apologies @chingor13 didn't realize automation would assign you. Feel free to review as well if you'd like! |
jskeet
approved these changes
Jun 3, 2026
Contributor
jskeet
left a comment
jskeet
left a comment
There was a problem hiding this comment.
One nit, but basically fine - assuming I actually understand it...
| updateContent(content: string): string { | ||
| return content.replace( | ||
| /const Version = "[0-9]+\.[0-9]+\.[0-9](-\w+)?"/, | ||
| /const Version = "[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z-.]+)??"/, |
Contributor
There was a problem hiding this comment.
Is the second question mark at the end required?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the version value in
internal/verison.gohad a SemVer prerelease suffix with dot separated segments (https://semver.org/#spec-item-9) e.g.1.2.3-rc.1, the version updater wouldn't match the string and wouldn't update it with the new version.Discovered this while testing release-please for previews (googleapis/librarian#6115 (comment)), where we expect to use dot-separated prerelease segments.