-
Notifications
You must be signed in to change notification settings - Fork 70
deps: Downgrade opentelemetry to 1.51.0 #4075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a dependency management concern by reverting the OpenTelemetry version within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully downgrades the opentelemetry.version from 1.52.0 to 1.51.0 in gapic-generator-java-pom-parent/pom.xml. This change aligns with the pull request title and appears to be a straightforward dependency version update.
|
|



v1.52.0 of opentelemetry-exporter-sender-okhttp and opentelemetry-sdk-extension-jaeger-remote-sampler now requires OkHttp 5.x which is incompatible with customers still rely on 4.x. Even though we don't use these two artifacts in client libraries, they are included in the opentelemetry-bom. If a customer uses v1.51.0 version of opentelemetry-bom and latest client libraries, they would get enforcer errors.
Downgrade the opentelemetry version to 1.51.0 to give customers more time to migrate their codebase to be compatible with Okhttp 5.x and opentelemetry 1.52+.