When coding in Dutch, ij should not look like a single narrow letter.#34
Open
moyogo wants to merge 2 commits intogooglefonts:mainfrom
Open
When coding in Dutch, ij should not look like a single narrow letter.#34moyogo wants to merge 2 commits intogooglefonts:mainfrom
moyogo wants to merge 2 commits intogooglefonts:mainfrom
Conversation
Collaborator
|
Thanks for the patch and the insights, @moyogo! Would you not do this is a proportional typeface either and handle it using stylistic sets? Thanks in advance! |
Author
|
@kalapi 👋🏽 The Glyphs app Dutch localization tutorial removed the Stylistic sets are adequate for these two behaviours in some styles. It’s not clear if there’s a use case for a monospace coding font. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current feature code
sub i j by ijandsub iacute j by ijacute;, and the equivalent substitutions for capitals in the locl NLD for Dutch are an anti-pattern, especially in coding context.The current Google Sans Code shows ij in an unexpected manner in monospace context when applications are showing code in Dutch:

In comparison Noto Sans Mono shows ij as expected:

This patch disables the locl NLD feature and replaces the
sub iacute j by ijacute;in locl NLD bysub ij acutecomb by ijacute;in ccmp default.For example:

Doing such a substitution is an anti-pattern, it is counterproductive and break things rather than solve the problem it is trying to solve. The Taalunie, the standard body in charge of the Dutch language, considers ij to be a digraph i+j that behaves like a letter in some contexts, for example in crosswords (ij in one cell) or when capitalized at the beginning of words (IJzer). There are also cases where ij is purely a digraph, for example in foreign or borrowed words. There is no reason it should be a narrow letter by default, in particular when the characters IJ and ij are available for that purpose.
The acute on the j is usually omitted, as described in the official spelling rules, it shouldn’t be added by the font if it’s not in the character string. The standard way to have the j with acute is to use the combining acute with j. The current feature code breaks both:
