Fix JavaScript version of gcj2wgs_exact#60
Open
cxcxcxcx wants to merge 1 commit intogoogollee:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was actually failing:
% npm test
gcj2wgs_exact test 0: distance5695312.758504871
gcj2wgs_exact test 1: distance12596699.5673844
gcj2wgs_exact test 2: distance14679927.891650176
wgs2gcj 2564103 223 ns/op
gcj2wgs 3225806 213 ns/op
gcj2wgs_exact 348432 2770 ns/op
distance 9090909 11 ns/op
Now the errors are gone.