cl/convert:mod instead OutputDir in Package#346
Open
luoliwoshang wants to merge 1 commit intogoplus:mainfrom
Open
cl/convert:mod instead OutputDir in Package#346luoliwoshang wants to merge 1 commit intogoplus:mainfrom
luoliwoshang wants to merge 1 commit intogoplus:mainfrom
Conversation
3b933d1 to
c5e1578
Compare
c5e1578 to
69f8c6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
+ Coverage 80.84% 80.92% +0.08%
==========================================
Files 30 30
Lines 3638 3638
==========================================
+ Hits 2941 2944 +3
+ Misses 665 663 -2
+ Partials 32 31 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package修改为接受gopmod.Module替代当前的OutputDir在Package中的耦合,目前Package应该负责的是gogen.Package的构建,而之前的OutputDir会导致Package需要额外关心怎么去加载这个Mod以及Catch一些Error,但实际上这个原子能力应该只去关心怎么使用这个go.Mod带来的能力,而修改为gopmod.Module,调用者也可以更灵活的创建模块。The Package should currently be responsible for building gogen.Package, while the previous OutputDir would require Package to additionally handle how to load this Mod and catch some errors. In fact, this atomic capability should only focus on how to use the capabilities provided by go.Mod. By changing to gopmod.Module, the caller can also more flexibly create the module.