sqlite3/v1.0.2#88
Merged
MeteorsLiu merged 1 commit intomainfrom Jul 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SQLite3 Go bindings to version 1.0.2, focusing on converting method-style function bindings to package-level functions and expanding struct definitions for virtual table indexing.
- Converts receiver-based method calls to package-level functions using go:linkname directives
- Replaces placeholder struct fields with proper field definitions for indexing structures
- Updates public API exports to include newly defined index-related types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sqlite3/sqlite3.go | Converts method bindings to package functions and defines proper struct fields for IndexConstraint, IndexOrderby, and IndexConstraintUsage |
| sqlite3/llcppg.pub | Exports newly defined index-related struct types in the public API |
Comments suppressed due to low confidence (3)
sqlite3/sqlite3.go:1088
- Parameter name '__llgo_arg_0' is not descriptive. Consider using 'db' or 'sqlite' to match the receiver pattern from the original method.
func DbConfig(__llgo_arg_0 *Sqlite3, op c.Int, __llgo_va_list ...interface{}) c.Int
sqlite3/sqlite3.go:6458
- Parameter name '__llgo_arg_0' is not descriptive. Consider using 'str' or 's' to match the receiver pattern from the original method.
func StrAppendf(__llgo_arg_0 *Str, zFormat *c.Char, __llgo_va_list ...interface{})
sqlite3/sqlite3.go:7292
- Parameter name '__llgo_arg_0' is not descriptive. Consider using 'db' or 'sqlite' to match the receiver pattern from the original method.
func VtabConfig(__llgo_arg_0 *Sqlite3, op c.Int, __llgo_va_list ...interface{}) c.Int
MeteorsLiu
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.