feat: screen bounds as foreground#65
Open
luckasRanarison wants to merge 1 commit intogorbit99:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a hack using extmark and it is ridiculously simple. Not completely unrelated but I also noticed a weird behavior with tree-sitter highlights, I get different highlighting on the minimap every time I open the same file, the position and even the color of some highlights change randomly (this is also the case with your previous implementation using nvim_buf_add_highlight). I don't know if it's a parsing issue or a buffer synchronization problem, EDIT: I opened an issue for it #66 .
Also regarding my previous PR I just realized linking the CodewindowBoundsBackground to CursorLine was a bad idea and we should set a default bg instead because not every theme has a bg with CursorLine.