nvim-treesitter re-write changes remove ts_utils#86
Open
taylrfnt wants to merge 2 commits intogorbit99:masterfrom
Open
nvim-treesitter re-write changes remove ts_utils#86taylrfnt wants to merge 2 commits intogorbit99:masterfrom
taylrfnt wants to merge 2 commits intogorbit99:masterfrom
Conversation
2 tasks
|
When I checkout your fork with these changes, I get an indexing error: This error occurs when toggling the codewindow on. |
Author
|
Hm, interesting. Can you share your neovim version, Treesitter version, and maybe the file that's the active buffer when you're attempting to toggle code window on? I'd like to try and find a fix for this case if possible, but I've been unsuccessful in reproducing so far. |
Author
|
@rhamilt I cracked open the code again with vim docs side-by-side and found a bug in my column index handling that might be the cause of your issue. Can you try again with the latest commit on my fork? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR addresses some of the more modern nvim-treesitter rewrites, which break a lot of the common ts_utils and other utility calls.
the changes in the commit below remove the call to
ts_utilsand instead offset the coords from 0-indexed treesitter cords to 1-index vim coords.I was able to test this successfully locally against treesitter's
mainbranch and nvim v0.11.5.This addresses #84
Hoping this helps anyone else who runs into a similar issue running the unstable treesitter rewrite :)