Skip to content

Remove the dedicated MOUs list page#2919

Merged
theseanything merged 5 commits into
mainfrom
remove-mous-list-page
Jul 24, 2026
Merged

Remove the dedicated MOUs list page#2919
theseanything merged 5 commits into
mainfrom
remove-mous-list-page

Conversation

@theseanything

@theseanything theseanything commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Removes the standalone MOUs list page at /mous in favour of the MOUs and agreements shown on the organisation pages.

The organisations pages list each organisation's signed MOUs and agreements (and the organisations index shows MOU-signed status with filtering), so the separate list page is redundant. The header navigation and sitemap now point at the organisations pages instead, and the MouSignaturePolicy is removed as nothing uses it any more. The MOU signing flow is unchanged.

The locale keys the list page shared with the organisation pages have also moved out of the mou_signatures.index namespace, since there is no longer an index page for them to belong to.

@theseanything
theseanything force-pushed the remove-mous-list-page branch 2 times, most recently from 5d1bcd9 to d43abd6 Compare July 14, 2026 11:17
@theseanything
theseanything force-pushed the remove-mous-list-page branch 3 times, most recently from 4c9699d to 4a461f4 Compare July 24, 2026 11:42
The sitemap links to the dedicated MOUs list page, which is being
removed now that the organisations pages show each organisation's
signed MOUs and agreements.

Replace the sitemap's MOUs heading with a link to the organisations
page, gated on the organisation policy instead of the MOU policy. The
link to the MOU signing page is kept.
The dedicated MOUs list page is being removed now that the
organisations pages show each organisation's signed MOUs and
agreements.

Drop the MOUs item from the header navigation, since super admins can
reach the same information through the Organisations item. Update the
service navigation component preview to match what super admins now
see.
The organisations pages now show each organisation's signed MOUs and
agreements, making the standalone list at /mous redundant.

Remove the route, the controller's index action and its authorisation
callbacks, the view and its spec, and the locale strings only that view
used. The MOU signing flow is unchanged.
Its last caller was the MOUs list page's index action, which has been
removed. The sitemap and header navigation now use the organisation
policy instead.
The mou_signatures.index locale namespace referred to the MOUs list
view, which no longer exists. Its surviving keys are only used by the
organisations pages, so home them where they are consumed: the
agreement type labels move to mou_signatures.agreement_type as they
describe the model's enum and are shared between the organisations
index, show and filter, while the table headings, preamble and share
links move under organisations.show.mou_signatures alongside the
existing heading. This stops the keys looking like dead code tied to a
deleted view.
@theseanything
theseanything force-pushed the remove-mous-list-page branch from 4a461f4 to 11f1594 Compare July 24, 2026 11:58
@theseanything
theseanything marked this pull request as ready for review July 24, 2026 11:59
@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2919.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@theseanything
theseanything added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit ef3a37d Jul 24, 2026
4 checks passed
@theseanything
theseanything deleted the remove-mous-list-page branch July 24, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants