Update content for delivery configurations#2964
Open
stephencdaly wants to merge 3 commits into
Open
Conversation
Update content in the details component on the submission email page to reflect that email submissions can remain switched on when submissions to an S3 bucket are configured.
stephencdaly
force-pushed
the
update-content-for-delivery-configurations
branch
from
July 23, 2026 08:47
3858c7d to
e4e7da4
Compare
stephencdaly
marked this pull request as ready for review
July 23, 2026 08:54
On the live form page, if S3 bucket delivery is enabled, include a subheading "S3 bucket" with details about the bucket name and file format (CSV or JSON). If email delivery is not enabled, do not show the "Email" subheading and the submission email address.
The form didn't have a format set, which is required for S3 delivery.
stephencdaly
force-pushed
the
update-content-for-delivery-configurations
branch
from
July 23, 2026 11:50
e4e7da4 to
30593ac
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2964.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
| <p>You can get completed forms sent to an AWS S3 bucket instead of an email address.</p> | ||
| <p>To find out more about this option, including how to set it up, <a href="https://www.forms.service.gov.uk/processing-completed-form-submissions">read our guidance on processing completed form submissions</a>.</p> | ||
| <p>You still need to set an email address here to mark this task complete. When you switch to an S3 bucket, you’ll stop getting completed forms by email.</p> | ||
| <p>You still need to set an email address here to mark this task complete, even if you do not want to want to receive submissions by email over the long term.</p> |
Contributor
There was a problem hiding this comment.
Suggested change
| <p>You still need to set an email address here to mark this task complete, even if you do not want to want to receive submissions by email over the long term.</p> | |
| <p>You still need to set an email address here to mark this task complete, even if you do not want to receive submissions by email over the long term.</p> |
Contributor
There was a problem hiding this comment.
Or maybe something like this?
Suggested change
| <p>You still need to set an email address here to mark this task complete, even if you do not want to want to receive submissions by email over the long term.</p> | |
| <p>You still need to set an email address here to mark this task complete, even if you plan to get completed forms in an S3 bucket instead.</p> |
Contributor
Author
There was a problem hiding this comment.
Ah good spot with the repetition, I didn't proof-read this.
In terms of the different content suggestion, what do you think @StephenGill?
| <p>To find out more about this option, including how to set it up, <a href="https://www.forms.service.gov.uk/processing-completed-form-submissions">read our guidance on processing completed form submissions</a>.</p> | ||
| <p>You still need to set an email address here to mark this task complete. When you switch to an S3 bucket, you’ll stop getting completed forms by email.</p> | ||
| <p>You still need to set an email address here to mark this task complete, even if you do not want to want to receive submissions by email over the long term.</p> | ||
| <p>To find out how to set an S3 bucket, <a href="https://www.forms.service.gov.uk/processing-completed-form-submissions">read our guidance on processing completed form submissions</a>.</p> |
Contributor
There was a problem hiding this comment.
Suggested change
| <p>To find out how to set an S3 bucket, <a href="https://www.forms.service.gov.uk/processing-completed-form-submissions">read our guidance on processing completed form submissions</a>.</p> | |
| <p>To find out how to set up an S3 bucket, <a href="https://www.forms.service.gov.uk/processing-completed-form-submissions">read our guidance on processing completed form submissions</a>.</p> |
theseanything
approved these changes
Jul 24, 2026
theseanything
left a comment
theseanything
left a comment
Contributor
There was a problem hiding this comment.
From a code perspective looks fine! Might need a content review - but still an improvement either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/WMnjLlJV/245-allow-both-email-and-s3-submissions-simultaneously
Update:
New details component content:
Live form page for a form with both email and S3 enabled:
Live form page for a form with only S3 submissions enabled:
Things to consider when reviewing