Ignore unused form attributes#2970
Open
stephencdaly wants to merge 2 commits into
Open
Conversation
This has been run on all environments and needs to be deleted so we can ignore the deprecated Form columns.
The following attributes are no longer used by forms-admin or forms-runner, so can be ignored in preparation for dropping the columns: - submission_type - submission_format - send_daily_submission_batch - send_weekly_submission_batch
stephencdaly
changed the title
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2970.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/WMnjLlJV/245-allow-both-email-and-s3-submissions-simultaneously
The following attributes are no longer used by forms-admin or forms-runner, so can be ignored in preparation for dropping the columns:
Things to consider when reviewing