Add custom branding#2223
Conversation
ee8d41f to
8e82014
Compare
Co-authored-by: David Biddle <david.biddle@digital.cabinet-office.gov.uk>
Co-authored-by: David Biddle <david.biddle@digital.cabinet-office.gov.uk>
Co-authored-by: David Biddle <david.biddle@digital.cabinet-office.gov.uk>
Co-authored-by: David Biddle <david.biddle@digital.cabinet-office.gov.uk>
This should make styling easier - we won't have to add individual classes to the HTML of each component we style.
Adds a new component to contain the `<style>` tag and custom CSS for the custom branding feature in one place.
Major email clients have trouble with data URIs (Gmail doesn't support them at all, Outlook seems to render them inconsistently). If we want to include custom branding in emails, we'll need to include URLs to existing files. For now the brand assets can live in the public folder. Later we can figure out how to store them in a way that makes self-service in forms-admin possible.
Co-authored-by: David Biddle <david.biddle@digital.cabinet-office.gov.uk>
When a form uses custom branding, show the branded accessibility statement link in the footer. Co-authored-by: David Biddle <david.biddle@digital.cabinet-office.gov.uk>
8e82014 to
6c2577d
Compare
|
🎉 A review copy of this PR has been deployed! It is made of up two components It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
theseanything
left a comment
theseanything
left a comment
There was a problem hiding this comment.
I think this is fine to go in now (considering it won't affect our user's at the moment) - it will allow us to iterate on it.
There was a problem hiding this comment.
Obviously these need to be translated into welsh - but can happen in a separate PR. Worth making a TODO
| organisation_name: "South Gloucestershire Council" | ||
| organisation_url: "https://www.southglos.gov.uk" | ||
| logo: /brand_assets/south-gloucestershire/logo.png | ||
| favicon: /brand_assets/south-gloucestershire/favicon.png |
There was a problem hiding this comment.
Nit: No opengraph for south Gloucestershire. Something to fix later.
| @@ -0,0 +1,15 @@ | |||
| cheshire-east: | |||
| background_colour: "white" | |||
There was a problem hiding this comment.
Can we use hex values for all colours (as they will be easier to validate, when injecting dynamic css values)?
3 participants
What problem does this pull request solve?
Trello card:
Things to consider when reviewing