Avoid cuBLAS in L2 persistence benchmark#52
Merged
Conversation
msaroufim
marked this pull request as ready for review
June 10, 2026 07:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate the L2 persistence test's expected output with an elementwise reduction instead of the benchmark helper that dispatches through cuBLAS. The benchmarked kernels still use the single-column GEMM path from #51; only expected-output setup avoids cuBLAS.
Root cause
The main-branch CI failure after #51 happened at expected-output generation, before timing started:
That showed the instability was using cuBLAS during test-case setup, not specifically GEMV.
Validation before opening
python3 -m py_compile test/l2_persistence.pygit diff --check07424cc/run27250846501wheel artifact passed, includingl2_persistence.pywithOK: L2 persistence confers no benchmark advantage.I am leaving this as draft until the PR's own GitHub Actions run is green.