chore(PROC-1668): release as 2.0.0 (recover from malformed squash subject)#135
Merged
Merged
Conversation
The squash commit for #134 landed as `feat!(PROC-1668):` (the legacy type-then-bang form), which release-please's conventional-commits parser rejects. Job 25515561069 logged "commit could not be parsed" and skipped opening the release PR, so v2.0.0 never got cut. This empty commit's `Release-As: 2.0.0` footer forces release-please to open the v2.0.0 Release PR off this commit. **When squash-merging this PR, the `Release-As: 2.0.0` footer below must be preserved in the squash-commit message body** — release-please reads it from the commit on `main`. Release-As: 2.0.0 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CalNightingale
added a commit
that referenced
this pull request
May 7, 2026
Release-please failed to parse the squashed `feat!(PROC-1668):` subject from #134 and skipped it, leaving v2.0.0 listing only the trigger chore from #135. This rewrites the entry under the correct BREAKING CHANGES + Features sections so the published changelog reflects the actual user-facing change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CalNightingale
added a commit
that referenced
this pull request
May 7, 2026
Release-please failed to parse the squashed `feat!(PROC-1668):` subject from #134 and skipped it, leaving v2.0.0 listing only the trigger chore from #135. This rewrites the entry under the correct BREAKING CHANGES + Features sections so the published changelog reflects the actual user-facing change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The squash-merge of #134 landed on
mainasfeat!(PROC-1668): drop pydicom3 fork ...— the legacytype!(scope):form. Release-please's conventional-commits parser rejects it (commit could not be parsed, run #25515561069) and silently skipped opening a release PR. No v2.0.0 tag was cut, nothing went to PyPI, but the action reports success.This is the same recovery pattern as #99: an otherwise-empty commit with a
Release-As: 2.0.0footer forces release-please to open a "chore(main): release 2.0.0" PR off this commit.Squash-merge and preserve the
Release-As: 2.0.0footer in the squash-commit body. Release-please reads it from the commit onmain, not from the PR. If GitHub strips it from the auto-filled commit message, paste it back before clicking "Confirm squash and merge".Release-As: 2.0.0
Test plan
Release-As: 2.0.0footer preserved in the commit bodychore(main): release 2.0.0PRv2.0.0tag,pyproject.tomlbumped to2.0.0, CHANGELOG updated, wheel published to PyPI🤖 Generated with Claude Code