Add optional thread name labels to pprof profiles in JFR conversion#59
Draft
korniltsev wants to merge 5 commits into
Draft
Add optional thread name labels to pprof profiles in JFR conversion#59korniltsev wants to merge 5 commits into
korniltsev wants to merge 5 commits into
Conversation
This commit implements a new optional feature that adds thread names as pprof sample labels during JFR to pprof conversion. Fixes: grafana/pyroscope#4331 Key changes: - Added WithThreadNameLabels(bool) configuration option - Enhanced ProfileBuilder to support thread name labels via new AddExternalSampleWithLabelsAndThread method - Thread names extracted with fallback hierarchy: JavaName → OsName → "[thread]" - Added GetThread() method to parser for thread information access - All JFR event types now support thread name labels - Comprehensive test coverage with TestThreadNameLabels() - Feature is disabled by default for backward compatibility Usage: profiles, err := pprof.ParseJFR(data, input, nil, pprof.WithThreadNameLabels(true)) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Extract getThreadName() helper function with fallback hierarchy - Extract thread name only once if either thread root frame or thread name labels is enabled - Improve efficiency by avoiding duplicate GetThread() calls and name resolution - Maintain same functionality and behavior for both features Co-Authored-By: Claude <noreply@anthropic.com>
korniltsev
commented
Aug 1, 2025
| } | ||
|
|
||
| // getThreadName extracts thread name with fallback hierarchy: JavaName → OsName → "[thread]" | ||
| func (b *jfrPprofBuilders) getThreadName(threadRef types.ThreadRef) string { |
Contributor
Author
There was a problem hiding this comment.
It should have an option to efficiently process/merge thread names, in case it has too much cardinality and it is a problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a new optional feature that adds thread names as pprof sample labels during JFR to pprof conversion.
Fixes: grafana/pyroscope#4331
Key Features
WithThreadNameLabels(bool)to enable thread name labelsthread_namelabels to pprof samples when enabledImplementation Details
GetThread()method to parser for accessing thread informationProfileBuilderwithAddExternalSampleWithLabelsAndThread()methodTesting
TestThreadNameLabels()🤖 Generated with Claude Code