fix(ci): install Playwright firefox and webkit for browser matrix#2
Conversation
CI only installed chromium while runDemo runs 36 projects across six browser families. Firefox and WebKit engines were missing, causing half of tests to fail with browserType.launch executable errors. Co-authored-by: Joshua Pendragon <graffhyrum@users.noreply.github.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow's Playwright browser installation step now installs Chromium, Firefox, and WebKit instead of only Chromium, enabling cross-browser test execution in continuous integration. ChangesMulti-browser Playwright CI Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Root cause
GitHub Actions installs only Chromium (
playwright install --with-deps chromium), butgetProjects()generates 36 projects across six browser families (chromium, firefox, webkit, Mobile Chrome, Mobile Safari, Google Chrome).Projects using firefox or webkit fail immediately:
Latest failing run: 24491485859 — 36 passed / 36 failed (chromium + Mobile Chrome + Google Chrome channel vs missing firefox/webkit).
Earlier failures (9–14s) were transient
package.jsonparse errors on broken commits; unrelated to the current matrix issue.Fix
Install the three Playwright-managed engines used by the matrix:
bunx playwright install --with-deps chromium firefox webkitMobile Chrome/Safari and Google Chrome channel reuse those binaries on Ubuntu runners.
Verification
Locally with
CI=trueand the same browser install: 72 passed viabun run runDemo(~51s).Summary by CodeRabbit