Skip to content

fix(ci): install Playwright firefox and webkit for browser matrix#2

Merged
graffhyrum merged 1 commit into
mainfrom
cursor/fix-ci-playwright-browsers-5736
May 22, 2026
Merged

fix(ci): install Playwright firefox and webkit for browser matrix#2
graffhyrum merged 1 commit into
mainfrom
cursor/fix-ci-playwright-browsers-5736

Conversation

@graffhyrum
Copy link
Copy Markdown
Owner

@graffhyrum graffhyrum commented May 22, 2026

Root cause

GitHub Actions installs only Chromium (playwright install --with-deps chromium), but getProjects() generates 36 projects across six browser families (chromium, firefox, webkit, Mobile Chrome, Mobile Safari, Google Chrome).

Projects using firefox or webkit fail immediately:

browserType.launch: Executable doesn't exist at .../ms-playwright/firefox-*/...
browserType.launch: Executable doesn't exist at .../ms-playwright/webkit-*/...

Latest failing run: 2449148585936 passed / 36 failed (chromium + Mobile Chrome + Google Chrome channel vs missing firefox/webkit).

Earlier failures (9–14s) were transient package.json parse errors on broken commits; unrelated to the current matrix issue.

Fix

Install the three Playwright-managed engines used by the matrix:

bunx playwright install --with-deps chromium firefox webkit

Mobile Chrome/Safari and Google Chrome channel reuse those binaries on Ubuntu runners.

Verification

Locally with CI=true and the same browser install: 72 passed via bun run runDemo (~51s).

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Chores
    • Expanded CI/CD browser compatibility testing to validate across Chromium, Firefox, and WebKit, improving cross-browser quality assurance.

Review Change Stack

CI only installed chromium while runDemo runs 36 projects across six
browser families. Firefox and WebKit engines were missing, causing half
of tests to fail with browserType.launch executable errors.

Co-authored-by: Joshua Pendragon <graffhyrum@users.noreply.github.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 22, 2026

⚠️ No Changeset found

Latest commit: 63451b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9838b9af-83f8-4ad5-91f7-32d5a42c60a5

📥 Commits

Reviewing files that changed from the base of the PR and between d06b08a and 63451b6.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The CI workflow's Playwright browser installation step now installs Chromium, Firefox, and WebKit instead of only Chromium, enabling cross-browser test execution in continuous integration.

Changes

Multi-browser Playwright CI Configuration

Layer / File(s) Summary
Playwright multi-browser installation
.github/workflows/ci.yml
Playwright install command updated to include firefox and webkit alongside chromium with the --with-deps flag for full dependency installation across all three browsers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A browser test in every hue,
Chrome, Firefox, Webkit too,
Three browsers now in CI's embrace,
Cross-platform coverage finds its place! 🌈

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: installing multiple Playwright browsers (Firefox and WebKit) for the CI workflow's browser matrix testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-ci-playwright-browsers-5736

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@graffhyrum graffhyrum marked this pull request as ready for review May 22, 2026 00:09
@graffhyrum graffhyrum merged commit 4b53359 into main May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants