Skip to content

fix: address Copilot PR #7 review feedback #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gragra33 wants to merge 1 commit into from
Closed

fix: address Copilot PR #7 review feedback #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
branches:
- master

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

jobs:
release:
name: Build, Test & Publish to NuGet
Expand Down Expand Up @@ -53,6 +57,12 @@ jobs:
echo "exists=false" >> $GITHUB_OUTPUT
fi

- name: Fail if this version was already released
if: steps.tag_check.outputs.exists == 'true'
run: |
echo "::error::Release tag ${{ steps.version.outputs.tag }} already exists. Bump the project version before pushing to master."
exit 1

- name: Pack NuGet package
if: steps.tag_check.outputs.exists == 'false'
run: |
Expand Down
4 changes: 2 additions & 2 deletions tests/Blazing.Json.Queryable.Tests/CollectionDefinitions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ namespace Blazing.Json.Queryable.Tests;
/// </summary>
/// <remarks>
/// <para>
/// <see cref="DisableParallelization"/> is set to <see langword="true"/> so that when any
/// <see cref="Xunit.CollectionDefinitionAttribute.DisableParallelization"/> is set to <see langword="true"/> so that when any
/// test in this collection executes, no other test collection runs concurrently.
/// </para>
/// <para>
/// This is required because <see cref="Blazing.Json.Queryable.Implementations.SpanPropertyAccessor"/>
/// uses a process-wide static <see cref="System.Collections.Concurrent.ConcurrentDictionary{TKey, TValue}"/>
/// uses a process-wide static <see cref="System.Collections.Concurrent.ConcurrentDictionary{TKey,TValue}"/>
/// cache. Tests in this collection call <c>ClearCache()</c> and assert on <c>CacheCount</c> —
/// assertions that are only valid when no other test is concurrently populating the cache.
/// </para>
Expand Down