fix: address Copilot PR #7 review feedback#9
Merged
Conversation
- release.yml: add concurrency group to prevent race conditions when
multiple pushes to master happen close together; cancel-in-progress
is false so a running release is never aborted mid-way
- release.yml: add explicit 'Fail if this version was already released'
step after tag_check so a duplicate-version push to master fails
loudly with ::error:: rather than silently succeeding with no publish
- CollectionDefinitions.cs: fix XML doc cref targets — qualify
DisableParallelization as Xunit.CollectionDefinitionAttribute.DisableParallelization
and remove the space in ConcurrentDictionary{TKey,TValue} to avoid
CS1574 warnings when doc generation is enabled
There was a problem hiding this comment.
Pull request overview
This PR addresses prior review feedback by tightening the release workflow’s behavior under concurrent pushes and cleaning up XML documentation cref references in the test suite to avoid doc-generation warnings.
Changes:
- Add workflow-level
concurrencyto serializemasterrelease runs. - Fail the release job explicitly when the computed release tag already exists.
- Fix XML doc
creftargets in test collection definitions to avoid CS1574 warnings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Serializes release runs and adds an explicit failure step when a tag already exists, preventing silent no-op releases. |
tests/Blazing.Json.Queryable.Tests/CollectionDefinitions.cs |
Updates XML doc cref targets to correct fully-qualified references and valid generic formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 3 Copilot review comments from PR #7.
Changes
.github/workflows/release.ymlconcurrencygroup (${{ github.workflow }}-${{ github.ref }},cancel-in-progress: false) — prevents race conditions when multiple pushes tomasterhappen close together; an in-flight release is never aborted mid-wayFail if this version was already releasedstep aftertag_check— when the tag already exists the job now fails loudly with::error::andexit 1instead of silently succeeding with nothing publishedtests/Blazing.Json.Queryable.Tests/CollectionDefinitions.cscreftargets:DisableParallelization→Xunit.CollectionDefinitionAttribute.DisableParallelization;ConcurrentDictionary{TKey, TValue}→ConcurrentDictionary{TKey,TValue}(space removed to avoid CS1574 warnings if doc generation is enabled for the test project)Test Results
All 487 tests pass.