Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines numeric input coercion to ensure GraphQL Float arguments and nullable float inputs correctly accept int64 values (commonly produced by large integer literals/variables), and expands regression coverage around that behavior.
Changes:
- Allow
NullFloat.UnmarshalGraphQLto coerceint64inputs tofloat64. - Extend the internal input packer to coerce
int64intofloat64when the target type isfloat64. - Expand issue/regression tests to cover
int32/int64behavior for a customInt64scalar and forFloatarguments (including large positive/negative values).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nullable_types.go | Adds int64 handling to NullFloat GraphQL unmarshalling. |
| nullable_types_test.go | Adds a test case ensuring NullFloat accepts int64 input. |
| issue_305_test.go | Broadens regression coverage for integer-literal/variable coercion, including large values and Float args. |
| internal/exec/packer/packer.go | Adds int64 -> float64 coercion in UnmarshalInput for reflect.Float64. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.