Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions .github/workflows/golang-ci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,8 @@ jobs:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v6
- name: golangci-lint
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v9.0.0
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.29

# Optional: working directory, useful for monorepos
# working-directory: somedir

# Optional: golangci-lint command line arguments.
# args: --issues-exit-code=0

# Optional: show only new issues if it's a pull request. The default value is `false`.
# only-new-issues: true
version: latest
4 changes: 2 additions & 2 deletions google/creds.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ func (cm *credentialsManager) loadCreds(c *Client) error {
if err != nil {
return err
}
defer f.Close()
defer f.Close() //nolint:errcheck
var token oauth2.Token
if err := json.NewDecoder(f).Decode(&token); err != nil {
return err
Expand All @@ -34,7 +34,7 @@ func (cm *credentialsManager) saveCreds(c *Client) error {
if err != nil {
return err
}
defer f.Close()
defer f.Close() //nolint:errcheck
return json.NewEncoder(f).Encode(c.credentials)
}

Expand Down
2 changes: 1 addition & 1 deletion google/google.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func NewClientFromFile(logger *log.Logger, path string, options ...ClientOption)
if err != nil {
return nil, err
}
defer f.Close()
defer f.Close() //nolint:errcheck
return NewClientFromReader(logger, f, options...)
}

Expand Down
4 changes: 2 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ func NewConfigFromFile(logger *log.Logger, path string, googleClient *google.Cli
if f == nil {
r = bytes.NewReader(nil)
} else {
defer f.Close()
defer f.Close() //nolint:errcheck
}

return NewConfigFromReader(logger, r, googleClient, zoomClient, slackClient)
Expand Down Expand Up @@ -436,7 +436,7 @@ func (z *Config) Archive(ctx context.Context, meeting zoom.Meeting, params runPa
curArchMeeting.status = "error"
return fmt.Errorf("while downloading recording %s: %w", f.DownloadURL, err)
}
defer r.Body.Close()
defer r.Body.Close() //nolint:errcheck

if r.StatusCode != http.StatusOK {
curArchMeeting.status = "error"
Expand Down
2 changes: 1 addition & 1 deletion slack/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func NewClientFromFile(logger *log.Logger, path string, options ...slackapi.Opti
if err != nil {
return nil, err
}
defer f.Close()
defer f.Close() //nolint:errcheck
return NewClientFromReader(logger, f, options...)
}

Expand Down
4 changes: 2 additions & 2 deletions zoom/creds.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ func (cm *credentialsManager) loadCreds(c *Client) error {
if err != nil {
return err
}
defer f.Close()
defer f.Close() //nolint:errcheck
var token oauth2.Token
if err := json.NewDecoder(f).Decode(&token); err != nil {
return err
Expand All @@ -34,7 +34,7 @@ func (cm *credentialsManager) saveCreds(c *Client) error {
if err != nil {
return err
}
defer f.Close()
defer f.Close() //nolint:errcheck
return json.NewEncoder(f).Encode(c.credentials)
}

Expand Down
4 changes: 2 additions & 2 deletions zoom/zoom.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func NewClientFromFile(logger *log.Logger, path string, options ...ClientOption)
if err != nil {
return nil, err
}
defer f.Close()
defer f.Close() //nolint:errcheck
return NewClientFromReader(logger, f, options...)
}

Expand Down Expand Up @@ -210,7 +210,7 @@ func (c *Client) Do(req *http.Request, decodeTo interface{}) (*http.Response, er
if err != nil {
return nil, fmt.Errorf("while creating http client in Do: %w", err)
}
defer rsp.Body.Close()
defer rsp.Body.Close() //nolint:errcheck
if rsp.StatusCode != http.StatusOK {
msg := fmt.Sprintf("API call to %s failed: %d", req.URL.String(), rsp.StatusCode)
if body, err := ioutil.ReadAll(rsp.Body); err == nil {
Expand Down