Draft
Conversation
benjie
reviewed
Nov 6, 2019
Member
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Hey, thanks for the pull request! I'm afraid I'm unlikely to have sufficient time to properly review this approach in the next few weeks. I looked through it a bit but as you say the changes are quite extensive and I've got a lot of catching up to do on various other things. Feel free to ping me again end of November and I'll see if I can allocate some time to properly reviewing it; in the mean time I encourage you to get feedback from other PostGraphile/Federation users.
| kind: "Argument", | ||
| name: Name(argName), | ||
| value, | ||
| })), |
Member
There was a problem hiding this comment.
Let's extract the args logic into a helper function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows federation to work with multiple copies of postgraphile federated. The changes are quite extensive. See
examples/for multiple services federated together.Would love some feedback on general approach.