Conversation
ardatan
added
the
waits for release
ardatan
temporarily deployed
to
storybook-preview
GitHub Actions
Inactive
|
There was a problem hiding this comment.
Pull request overview
Adds documentation for the Router “Demand Control” feature and wires it into the security and configuration docs navigation.
Changes:
- Add a new Demand Control security guide explaining the cost model, directives, enforcement modes, and observability.
- Add a new
demand_controlconfiguration reference page and link it from the guide. - Update existing security docs/navigation to reference and include the new Demand Control docs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/documentation/content/docs/router/security/operation-complexity.mdx | Adds a section pointing readers to Demand Control as complementary protection. |
| packages/documentation/content/docs/router/security/meta.json | Adds the new demand-control page to the Security nav. |
| packages/documentation/content/docs/router/security/demand-control.mdx | New conceptual + how-to documentation for Demand Control. |
| packages/documentation/content/docs/router/configuration/meta.json | Adds demand_control to the Configuration nav ordering. |
| packages/documentation/content/docs/router/configuration/demand_control.mdx | New configuration reference page for demand_control. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| ], | ||
| // If `include_extension_metadata` is enabled, you can also see the cost breakdown in extensions | ||
| "extensions": { | ||
| "cost": { |
There was a problem hiding this comment.
The fenced block is labeled as json, but it includes comment syntax (e.g. the // If include_extension_metadata... line, and also # ... comments elsewhere in the same snippet). That makes the example invalid JSON and may confuse readers/copy-paste. Consider removing comments from the snippet (move notes to surrounding prose) or switch the fence language to jsonc/javascript to match the syntax shown.
| ], | ||
| // If `include_extension_metadata` is enabled | ||
| "extensions": { | ||
| "cost": { | ||
| "estimated": 480, |
There was a problem hiding this comment.
This block is marked as json, but it contains a // If include_extension_metadata... comment line, which is not valid JSON. Move the note outside the snippet or change the code fence language to jsonc/javascript so the example remains copy-pastable.
Documentation for graphql-hive/router#902