Skip to content

connection: align remaining PageInfoType members as properties #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffreylo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

connection: align remaining PageInfoType members as properties #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/graphql_relay/connection/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,15 @@ class PageInfoType(Protocol):
def startCursor(self) -> Optional[ConnectionCursor]:
...

@property
def endCursor(self) -> Optional[ConnectionCursor]:
...

@property
def hasPreviousPage(self) -> bool:
...

@property
def hasNextPage(self) -> bool:
...

Expand Down
12 changes: 12 additions & 0 deletions tests/connection/test_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
connection_definitions,
connection_from_array,
forward_connection_args,
PageInfoType,
)

from ..utils import dedent
Expand Down Expand Up @@ -98,6 +99,17 @@ class User(NamedTuple):
schema = GraphQLSchema(query=query_type)


def describe_page_info_type():
def defines_all_members_as_properties():
for member_name in (
"startCursor",
"endCursor",
"hasPreviousPage",
"hasNextPage",
):
assert type(getattr(PageInfoType, member_name)) is property


def describe_connection_definition():
def includes_connection_and_edge_fields():
source = """
Expand Down