Skip to content

feat: Fragment arguments v16#4159

Closed
JoviDeCroock wants to merge 6 commits intographql:16.x.xfrom
JoviDeCroock:fragment-arguments-v16
Closed

feat: Fragment arguments v16#4159
JoviDeCroock wants to merge 6 commits intographql:16.x.xfrom
JoviDeCroock:fragment-arguments-v16

Conversation

@JoviDeCroock
Copy link
Copy Markdown
Contributor

@JoviDeCroock JoviDeCroock commented Aug 8, 2024 •
edited
Loading

This is the v16 implementation of #4015 and spec implementation of graphql/graphql-spec#1081

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2024

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@JoviDeCroock JoviDeCroock requested a review from a team August 8, 2024 15:20
@Urigo
Copy link
Copy Markdown
Contributor

Urigo commented Aug 12, 2024

For those who has a production use case for this, wants to use it and provide feedback, feel free to reach out to @the-guild-org and test it with our support using Yoga Server

@JoviDeCroock

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 13, 2024

@github-actions publish-pr-on-npm

@JoviDeCroock The latest changes of this PR are available on NPM as
graphql@16.9.0-canary.pr.4159.0fa29326c53fcd63c6473c7357c28aa13fa0019d
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-4159

@tobias-tengler tobias-tengler mentioned this pull request Aug 13, 2024
Draft
4 tasks
saihaj
saihaj reviewed Sep 3, 2024
View reviewed changes
Comment thread src/language/ast.ts
@yaacovCR
Copy link
Copy Markdown
Contributor

yaacovCR commented Sep 6, 2024

the PR to main #4015 has been merged, with some significant changes in implementation. we can try to backport that into v16.x.x

@JoviDeCroock
Copy link
Copy Markdown
Contributor Author

JoviDeCroock commented Sep 6, 2024

@yaacovCR I'll look into that later on when the v17 implementation is closer to solidifying

@JoviDeCroock JoviDeCroock force-pushed the fragment-arguments-v16 branch 7 times, most recently from 90412dd to 065c385 Compare September 8, 2024 09:11
@JoviDeCroock @yaacovCR
Apply changes from v17 branch
d47e25e 
Co-authored-by: Yaacov Rydzinski <yaacovCR@gmail.com>
@JoviDeCroock JoviDeCroock force-pushed the fragment-arguments-v16 branch from 065c385 to d47e25e Compare September 8, 2024 09:36
This was referenced Sep 26, 2024
Closed
Closed
Closed
@JoviDeCroock JoviDeCroock deleted the fragment-arguments-v16 branch November 5, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saihaj saihaj saihaj left review comments

+1 more reviewer

@Thompson1985 Thompson1985 Thompson1985 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoviDeCroock @Urigo @yaacovCR @saihaj @Thompson1985