validation: align MaxIntrospectionDepthRule with v16 backport#4583
Merged
yaacovCR merged 1 commit intographql:nextfrom Feb 20, 2026
Merged
Conversation
|
@benjie is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
benjie
reviewed
Feb 23, 2026
| if ( | ||
| node.kind === Kind.FIELD && | ||
| // check all introspection lists | ||
| // TODO: instead of relying on field names, check whether the type is a list |
Member
There was a problem hiding this comment.
Should restore this TODO (or implement it), otherwise newly added list fields in introspection will bypass the list depth limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See prior PRs: