Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
yaacovCR
force-pushed
the
v17-alpha
branch
2 times, most recently
from
1a2a9e4 to
46c1503
Compare
Refines #3548. See #3548 (comment)
Extracted from #3453 All credits goes to @thomasheyenbrock
Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
* Fix coerceInputValue test name * fix grammar
Motivation: I was inspecting code for unrelated reason and just spotted this pattern. I think it worth to refactor it since it easier to understand intention looking on code that uses Set's has/add methods. Benchmark shows no measurable changes in CPU/memory usages.
Motivation: Spotted during investigation of unrelated issue. Maps and sets are iteratable, so no need to call these methods.
Explanation: `Object.create(null)` returns value of `any` type. So bellow construct is not reported by TS even in "strict" mode: ```ts const foo = Object.create(null); ``` Fixing this issue in `extendSchema` requires adding more code since we can't put all extensions nodes into one collection without loosing typesafety.
…s` (#3655) * polish: add tests for more testUtils adds tests for expectPromise and expectEqualPromisesOrValues * break out expectMatchingValues into another file * apply review feedback
...as the function maps iterables (by extracting the iterator).
yaacovCR
force-pushed
the
v17-alpha
branch
11 times, most recently
from
8186680 to
4e459ce
Compare
Contributor
Author
|
looks like we can either merge this PR by splitting up all these commits, or just push v17-alpha as 17.x.x directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.