Skip to content

separate out IsSubType from IsValidImplementationFieldType #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leebyron merged 1 commit into from
Sep 1, 2022
Merged

separate out IsSubType from IsValidImplementationFieldType #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions spec/Section 3 -- Type System.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,14 +924,17 @@ IsValidImplementationFieldType(fieldType, implementedFieldType):
2. Let {implementedItemType} be the unwrapped item type of
{implementedFieldType}.
3. Return {IsValidImplementationFieldType(itemType, implementedItemType)}.
3. If {fieldType} is the same type as {implementedFieldType} then return {true}.
4. If {fieldType} is an Object type and {implementedFieldType} is a Union type
and {fieldType} is a possible type of {implementedFieldType} then return
{true}.
5. If {fieldType} is an Object or Interface type and {implementedFieldType} is
an Interface type and {fieldType} declares it implements
{implementedFieldType} then return {true}.
6. Otherwise return {false}.
3. Return {IsSubType(fieldType, implementedFieldType)}.

IsSubType(possibleSubType, superType):

1. If {possibleSubType} is the same type as {superType} then return {true}.
2. If {possibleSubType} is an Object type and {superType} is a Union type and
{possibleSubType} is a possible type of {superType} then return {true}.
3. If {possibleSubType} is an Object or Interface type and {superType} is an
Interface type and {possibleSubType} declares it implements {superType} then
return {true}.
4. Otherwise return {false}.

### Field Arguments

Expand Down