This repository was archived by the owner on Apr 11, 2025. It is now read-only.
build: change Dolphin to use mage-OS repository by default#65
Draft
MateusDadalto wants to merge 6 commits intomasterfrom
Draft
build: change Dolphin to use mage-OS repository by default#65MateusDadalto wants to merge 6 commits intomasterfrom
MateusDadalto wants to merge 6 commits intomasterfrom
Conversation
damienwebdev
suggested changes
Aug 4, 2022
Member
damienwebdev
left a comment
There was a problem hiding this comment.
I think we also need to change the Venia URL, right?
Contributor
Author
|
PR is failing because 2.3.7 and magento/module-wishlist-sample-data have dependency conflict. This is happening because we don't have older versions of magento/module-wishlist-sample-data in mage-os mirror Here's the log for it: https://github.com/graycoreio/mage2docker/runs/7680790648?check_suite_focus=true#step:9:3809 |
|
I'll add the required |
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Dolphin by default uses adobe's repo to install magento. This imply in having to setup a magento account and creating an access key for anyone who want to use dolphin.
Fixes: #66
What is the new behavior?
Change the default repository to be mage-OS. Mage-OS is the open initiative to maintain magento. It provides a Magento mirror that requires no authorization
Does this PR introduce a breaking change?
Other information