Skip to content

Rename hackrf_core.x to pins.x (3/3)#1710

Open
antoinevg wants to merge 2 commits intogreatscottgadgets:mainfrom
antoinevg:antoinevg/refactor-hackrf-core-pins
Open

Rename hackrf_core.x to pins.x (3/3)#1710
antoinevg wants to merge 2 commits intogreatscottgadgets:mainfrom
antoinevg:antoinevg/refactor-hackrf-core-pins

Conversation

@antoinevg
Copy link
Copy Markdown
Member

Depends on #1709


@antoinevg antoinevg marked this pull request as ready for review March 31, 2026 11:53
This was referenced Apr 2, 2026
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-pins branch from d476c72 to 61cc851 Compare April 2, 2026 07:39
@mossmann mossmann self-requested a review April 2, 2026 15:14
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-pins branch 4 times, most recently from 8c1762f to 17c3be6 Compare April 7, 2026 15:26
@antoinevg antoinevg changed the title Rename hackrf_core.x to pins.x Rename hackrf_core.x to pins.x (3/3) Apr 10, 2026
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-pins branch from 17c3be6 to 779ec1e Compare April 10, 2026 07:55
@antoinevg antoinevg marked this pull request as draft April 14, 2026 08:26
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-pins branch from 779ec1e to 0881fc6 Compare April 22, 2026 13:07
@antoinevg antoinevg marked this pull request as ready for review April 22, 2026 13:36
@antoinevg antoinevg marked this pull request as draft April 23, 2026 14:10
@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-pins branch from 15465bb to c6d30e2 Compare April 23, 2026 15:05
@antoinevg antoinevg marked this pull request as ready for review April 23, 2026 15:23
@antoinevg antoinevg marked this pull request as draft April 23, 2026 15:30
@antoinevg
Copy link
Copy Markdown
Member Author

I've put this back in draft for now because the hackrf_core.x rename operation got lost somewhere during rebase and it would be nice not to lose history.

@mossmann
Copy link
Copy Markdown
Member

If your concern is about GitHub representing the change to pins.x as a rename in "files changed" for the PR, I don't think you can control that detection. It is represented as a rename in the commit: 7cf005d

@antoinevg antoinevg force-pushed the antoinevg/refactor-hackrf-core-pins branch from c6d30e2 to 5396a16 Compare April 24, 2026 07:04
@antoinevg antoinevg marked this pull request as ready for review April 24, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants