Merged
Conversation
bjoernricks
force-pushed
the
gsad-envelope
branch
from
d90d840 to
66e39f5
Compare
Extract a gsad_envelope function from envelope_gmp and always use it for creating the envelope xml of the response. envelope_gmp follows the standard gmp function signature and accepts some unused arguments.
bjoernricks
force-pushed
the
gsad-envelope
branch
from
66e39f5 to
9270833
Compare
ozgen
reviewed
Apr 9, 2026
ozgen
previously approved these changes
Apr 9, 2026
`response_data` is and in and out parameter and is actually required.
ozgen
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a new gsad_envelope function
Why
Extract a gsad_envelope function from envelope_gmp and always use it for creating the envelope xml of the response. envelope_gmp follows the standard gmp function signature and accepts some unused arguments.
Also this change will create a standardized envelope.