Skip to content

Fix default lock file path#2266

Merged
Tehforsch merged 3 commits into
mainfrom
fix-default-lock-file-path
Jun 30, 2026
Merged

Fix default lock file path#2266
Tehforsch merged 3 commits into
mainfrom
fix-default-lock-file-path

Conversation

@Tehforsch

@Tehforsch Tehforsch commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

This fixes a regression in which we assume that the feed update lock file is available at /var/lib/openvas/plugins/feed-update.lock, but this is a very unlikely default when the feed path is set to something other than /var/lib/openvas/plugins.

This

  1. Fixes the above default to default to $FEED_PATH/feed-update.lock
  2. Fixes millions of sends on a closed channel polluting the logfile, obscuring the real issue
  3. Gracefully handles a missing lockfile by returning an error instead of panicking

Jira:
SC-1608
SC-1642

@Tehforsch Tehforsch requested a review from a team as a code owner June 30, 2026 13:37
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA be442ae.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@mergify

mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@Tehforsch Tehforsch force-pushed the fix-default-lock-file-path branch from 3f148c4 to be442ae Compare June 30, 2026 13:52
@github-actions github-actions Bot added the patch_release creates a patch release label Jun 30, 2026
@Tehforsch Tehforsch merged commit ace3531 into main Jun 30, 2026
36 checks passed
@Tehforsch Tehforsch deleted the fix-default-lock-file-path branch June 30, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch_release creates a patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants