Open
Conversation
rowanG077
force-pushed
the
interleave-write-verify
branch
from
6a0274b to
4610438
Compare
rowanG077
commented
Aug 21, 2023
| if (!disable_verify && interleaved_verify) { | ||
| flash_start_read(rw_offset + addr); | ||
| flash_continue_read(buffer_flash, rc); | ||
| flash_wait(); |
Contributor
Author
There was a problem hiding this comment.
@gregdavill From what I understand from SPI flash this wait here shouldn't be necessary. But without it the second page fails to write/read correctly.
rowanG077
force-pushed
the
interleave-write-verify
branch
from
4610438 to
61997bd
Compare
rowanG077
force-pushed
the
interleave-write-verify
branch
from
61997bd to
8218991
Compare
Contributor
Author
|
I now verifies in larger chunks. This makes it about 3x faster then before. It's competitive with normal verification mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.