This repository was archived by the owner on Jan 20, 2019. It is now read-only.
Fix authorize security group ingress#43
Open
jdrowell wants to merge 1 commit intogrempe:masterfrom
jdrowell:fix_authorize_security_group_ingress
Open
Fix authorize security group ingress#43jdrowell wants to merge 1 commit intogrempe:masterfrom jdrowell:fix_authorize_security_group_ingress
jdrowell wants to merge 1 commit intogrempe:masterfrom
jdrowell:fix_authorize_security_group_ingress
Conversation
RevokeSecurityGroupIngress as per the API description (API Version 2010-11-15). Does not implement multiple changes in one request (as supported by the API).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to implement "smart" port filtering in EC2 by specifying the security group name in the AWS console by that seems to be broken ("Save" button gets disabled). I then tried amazon-ec2 and got error messages (conflict between parameters). Looking at the most recent API the call seems to have changed. I updated the Authorize and Revoke methods to match the new API and managed to get the calls working. The data shows up correctly in the AWS console (still can't add other thru the console though :(). Modified the tests to match the new API. Use as such in awshell (ids were edited):
ruby-1.9.2-p0 :001 > r = @ec2.revoke_security_group_ingress :group_name => 'MongoDB', :ip_protocol => "tcp", :from_port => "27017", :to_port => "27017", :source_security_group_user_id => '6530123210223', :source_security_group_name => 'MongoDB'
=> {"xmlns"=>"http://ec2.amazonaws.com/doc/2010-08-31/", "requestId"=>"994023423d-5a49-443e-be5e-01899a806149", "return"=>"true"}