Handle assignments to global variables from the init function#4
Open
lizard-boy wants to merge 5 commits intomainfrom
Open
Handle assignments to global variables from the init function#4lizard-boy wants to merge 5 commits intomainfrom
lizard-boy wants to merge 5 commits intomainfrom
Conversation
There was a problem hiding this comment.
PR Summary
This PR adds new detection logic for assignments to global variables from init functions, enhancing how NilAway initializes and processes global variables.
- In /assertion/global/analyzer.go, getInitFuncDecls now collects init functions with a visited set to avoid infinite recursion; duplicate entries may occur across init functions.
- In /assertion/global/globalvarinit.go, analyzeValueSpec and getGlobalConsumers now accept init declarations, and hasGlobalVarAssignInInitFunc is added to detect global assignments.
- Consider caching repeated calls to hasGlobalVarAssignInInitFunc to improve efficiency and ensure proper logging using logger.error for failures.
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: uber-go/nilaway#253