Open
Conversation
…deling_points_outside_domain
JordiManyer
requested changes
Apr 9, 2025
Member
JordiManyer
left a comment
JordiManyer
left a comment
There was a problem hiding this comment.
Hi @lisavdlinde , thanks for the contribution! I do have some comments on the changes though.
- I've added some comments to the code.
- Also, please add
@notimplementedif searchmethod.accept_points_outsideto all functions that potentially allow the user to use the kwarg but which do not take it into consideration. For instance, the evaluation with an array of points.
src/CellData/CellFields.jl
Outdated
|
|
||
| end | ||
|
|
||
| if searchmethod.accept_points_outside == true |
src/CellData/CellFields.jl
Outdated
| end | ||
|
|
||
| if searchmethod.accept_points_outside == true | ||
| return nothing |
Member
There was a problem hiding this comment.
This is bad... We are turning a function that always returned an Int into something that sometimes returns a nothing, potentially making the whole thing slower.
I would change it to return 0.
src/CellData/CellFields.jl
Outdated
|
|
||
| cell = _point_to_cell!(cache1, x) | ||
| if cell == nothing | ||
| return nothing |
Member
There was a problem hiding this comment.
Same here. We are going from a function that returns something consistent to a returning sometimes nothing. I would change to
if iszero(cell)
return zero(return_type(testitem(cell_f),x))
end
Member
|
On top of this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.