Skip to content

Fix PV→PQ bus type conversion when bus rows are not in ID order #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yemine0x01 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix PV→PQ bus type conversion when bus rows are not in ID order #49

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cc90e9
Fix handling of PV buses without in-service generators by indexing ge…
yemine0x01 May 4, 2026
0a6dd5c
Merge branch 'main' into fix-deactivate-gens
yemine0x01 May 19, 2026
b271e43
Merge branch 'main' into fix-deactivate-gens
yemine0x01 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions gridfm_datakit/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,8 +421,10 @@ def deactivate_gens(self, idx_gens: np.ndarray) -> None:
gens_on = self.gens[self.idx_gens_in_service]
gen_count = np.bincount(gens_on[:, GEN_BUS].astype(int), minlength=n_buses)

# Boolean mask: PV buses with no in-service generator
pv_no_gen = (self.buses[:, BUS_TYPE] == PV) & (gen_count == 0)
# Boolean mask: PV buses with no in-service generator.
# Index gen_count by bus ID (not row index) to handle non-sorted bus ordering.
bus_ids = self.buses[:, BUS_I].astype(int)
pv_no_gen = (self.buses[:, BUS_TYPE] == PV) & (gen_count[bus_ids] == 0)

# Set them to PQ
self.buses[pv_no_gen, BUS_TYPE] = PQ
Expand Down
Loading