Open
Conversation
|
There's a bit of reformatting here, but I don't see significant tech debt reduction. Thus... it's safe to skip merging this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The project allows users to customize their room layout with various furniture as well as custom drawing capabilities to help with decoration. It has what looks to be a drag and drop functionality for dragging preexisting shapes/furniture onto the floor.
The program was available to be on time
The program is commented well enough to understand
The program Compiles
Three Concepts I learned:
Functions should not always be public, which is the default behavior, but rather sometimes it's better to have them as internal or private
The use of the strings.xml file, I was making some additions to that however decided against it as what I was doing would be adding a new feature so that is not part of this pull request.
How to use onClickListener to get finger position and use that information to for example, draw on the screen as done in this app.
My three Commites:
chintavs/Workout-App@5a1d069
chintavs/Workout-App@c997cfa
chintavs/Workout-App@4217f32