Bohman codereview2

[bohmanwl]

RoomRemix2 is a room design program that allows users to create a digital rendition of a room and fill it with furniture. It will connect with google marketplaces for various pieces of furniture's to help users create their ideal room arrangement.

Was the program available in UC Github on time?

• Yes
  Is the program documented/commented well enough for you to understand?
• Yes, it was way better than from the previous code review.
  Does the program compile?
• No, the version I copied seemed to have some incomplete segments of code, preventing compilation errors. Its also possible that there may just be an issue with my IDE.

Rational:
Most changes I made are an effort to make the code easier to read, and less repeatable. for example the chaining change I made, functionally; the function works the same, but its more streamlined. I removed saveFloorplan since it had no functionality and therefor shouldn't be in the master branch. The version of master I cloned only had 1 unit test, more should be implemented as your project grows to help test various parts of your code.

My Commits:
lh1207/LocoQuest@7e50361
lh1207/LocoQuest@24960f9
lh1207/LocoQuest@718867e
lh1207/LocoQuest@d7afe2c
lh1207/LocoQuest@4458491

Concepts I learned:

• How to chain setters instead of repeating lines.
• How you can better arrange your DAO.
• Various extended functions of Pallet Tools such as complimentary colors and shading

References:

• https://cswsolutions.com/blog/posts/2022/december/5-benefits-of-unit-testing-and-why-you-should-care/#:~:text=Unit%20tests%20can%20help%20you,released%20into%20the%20production%20environment.
• https://kotlinlang.org/docs/reference/coding-conventions.html

[discospiff]

Big no-no: do not put conversation in source code comments. That's clutter. Put the conversation here, in the Files Changed section of the pull request, where you can have a dialog with other developers.

[discospiff]

The scoped function apply {} is a good idea, though that can be implemented manually, and without the source code comment.

Beyond that, not a whole lot of tech debt reduction in this branch, so no need to merge it.

[discospiff]

Formatting can, and should, be performed automatically, and consistently, by the IDE. Formatting code is really programmer's preference anyway, and doesn't necessarily decrease technical debt.