Open
Conversation
Collaborator
Author
discospiff
reviewed
Apr 3, 2023
Comment on lines
-40
to
+47
| implementation 'androidx.core:core-ktx:1.7.0' | ||
| implementation 'androidx.core:core-ktx:1.9.0' | ||
| implementation 'androidx.appcompat:appcompat:1.6.1' | ||
| implementation 'com.google.android.material:material:1.8.0' | ||
| implementation 'androidx.constraintlayout:constraintlayout:2.1.4' | ||
| implementation 'androidx.core:core-ktx:+' | ||
| implementation 'androidx.annotation:annotation:1.3.0' | ||
| implementation 'androidx.lifecycle:lifecycle-livedata-ktx:2.4.1' | ||
| implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.1' | ||
| implementation 'androidx.core:core-ktx:1.9.0' | ||
| implementation 'androidx.annotation:annotation:1.6.0' | ||
| implementation 'androidx.lifecycle:lifecycle-livedata-ktx:2.5.1' | ||
| implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1' |
There was a problem hiding this comment.
Careful when changing dependencies. They tend to have dependencies on each other, so updating one can become a game of whac-a-mole.
discospiff
reviewed
Apr 3, 2023
Comment on lines
-25
to
+34
| init() | ||
| screenSmooth() | ||
| } | ||
| constructor(context: Context, attrs: AttributeSet?) : this(context, attrs, 0){ | ||
| init() | ||
| screenSmooth() | ||
| } | ||
|
|
||
| constructor(context: Context, attrs: AttributeSet?, defStyleAttr: Int) : super(context, attrs, defStyleAttr) { | ||
| init() | ||
| screenSmooth() | ||
| } | ||
| private fun init(){ | ||
| private fun screenSmooth(){ |
There was a problem hiding this comment.
init is the proper name for an initialization function, as this one appears to be. I'd keep this as it were.
There was a problem hiding this comment.
This is a direct copy of another student's code review.
discospiff
reviewed
Apr 3, 2023
Comment on lines
+49
to
+52
| fun isValidEmail(email: String): Boolean { | ||
| val emailRegex = Regex("^\\w+([.-]?\\w+)*@\\w+([.-]?\\w+)*(\\.\\w{2,})+\$") | ||
| return email.matches(emailRegex) | ||
| } |
There was a problem hiding this comment.
This is a direct copy of another student's code review.
|
Don't merge this branch. |
discospiff
reviewed
Apr 3, 2023
Comment on lines
-14
to
+29
| fun addition_isCorrect() { | ||
| assertEquals(4, 2 + 2) | ||
| fun `Given a exercise name contained within the json then I should recieve a list of muscles that are worked out by thte exercise`() { | ||
| givenJsonFileIsValid() | ||
| whenExerciseDataIsReadAndParsed() | ||
| thenExerciseCollectionShouldNotBeEmpty() | ||
| } private fun thenExerciseCollectionShouldNotBeEmpty() { | ||
| TODO("Not yet implemented") | ||
| } | ||
|
|
||
| private fun whenExerciseDataIsReadAndParsed() { | ||
| TODO("Not yet implemented") | ||
| } | ||
|
|
||
| private fun givenJsonFileIsValid() { | ||
| TODO("Not yet implemented") | ||
| } | ||
|
|
There was a problem hiding this comment.
Copied from : chintavs/Workout-App@4217f32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The project allows users to customize their room layout with various furniture pieces as well as custom drawing capabilities to help with decoration. Creators also created drag and drop function to test furniture pieces in a given room.
The program is constructed well and commented a throughout to understand
The program was available to be on time
The program runs
Three Concepts I learned:
Functions should not always be public.
New button implementation that cleans up the the format it is coded in.
How to use onClickListener to get pointer position , draw on the screen as done in this app.
References:
https://cswsolutions.com/blog/posts/2022/december/5-benefits-of-unit-testing-and-why-you-should-care/#:~:text=Unit%20tests%20can%20help%20you,released%20into%20the%20production%20environment.
https://kotlinlang.org/docs/reference/coding-conventions.html