Skip to content

Fix workflow syntax validation to handle Python files correctly#17

Merged
groupthinking merged 1 commit intomainfrom
copilot/sub-pr-4
Feb 6, 2026
Merged

Fix workflow syntax validation to handle Python files correctly#17
groupthinking merged 1 commit intomainfrom
copilot/sub-pr-4

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

The PR checks workflow was using node -c to validate all file types including Python, which fails silently due to || true. Additionally, the user requested this fix be applied via a new PR, but I clarified that I can only modify the current PR.

Changes needed:

  • Separate JS/TS validation (using node -c) from Python validation (using python -m py_compile)
  • Remove || true that masks all validation errors
  • Add conditional checks to only run validation when files of each type exist

Current issue in .github/workflows/pr-checks.yml:

find . -name "*.js" -o -name "*.py" -o -name "*.ts" | xargs -I {} node -c {} || true

Proposed fix:

js_ts_files=$(find . \( -name "*.js" -o -name "*.ts" \))
if [ -n "$js_ts_files" ]; then
  echo "$js_ts_files" | xargs -r -I {} node -c {}
fi

py_files=$(find . -name "*.py")
if [ -n "$py_files" ]; then
  echo "$py_files" | xargs -r -I {} python -m py_compile {}
fi

Note: I cannot create new pull requests. Awaiting confirmation to apply this fix to the current PR or provide guidance for manual PR creation.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Feb 5, 2026
Copilot AI changed the title [WIP] Update README.md for project clarification Fix workflow syntax validation to handle Python files correctly Feb 5, 2026
Copilot AI requested a review from groupthinking February 5, 2026 11:57
@groupthinking groupthinking marked this pull request as ready for review February 6, 2026 15:54
Copilot AI review requested due to automatic review settings February 6, 2026 15:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@groupthinking groupthinking merged commit 786cdee into main Feb 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants