refactor(credentials): make ServerCredentials trait dyn-compatible#2724
Open
sauravzg wants to merge 1 commit into
Open
refactor(credentials): make ServerCredentials trait dyn-compatible#2724sauravzg wants to merge 1 commit into
sauravzg wants to merge 1 commit into
Conversation
Contributor
Author
|
Since, this is a potentially breaking change , Do we need to bump up the crate versions here? |
sauravzg
force-pushed
the
sauravz/dyn-server-creds
branch
from
1608bee to
78b7f20
Compare
Member
We have a |
Mirror the ChannelCredentials dyn-compat treatment from upstream PR #2703: - Remove associated type Output<I> and generic accept<Input> - Use BoxEndpoint and #[async_trait] for object safety - Delete DynServerCredentials bridge trait (dyn_wrapper.rs) - Update LocalServerCredentials and RustlsServerCredendials impls
sauravzg
force-pushed
the
sauravz/dyn-server-creds
branch
from
78b7f20 to
1ff57ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror the ChannelCredentials dyn-compat treatment from upstream PR #2703: