Add support for setting a custom theme + add GitHub theme option.#98
Add support for setting a custom theme + add GitHub theme option.#98grafluxe wants to merge 3 commits intogruehle:masterfrom
Conversation
- Add "github" theme.
- GitHub CSS complements of <https://github.com/sindresorhus/github-markdown-css>
- Fix issue where the parsed file gets loaded twice.
- Update README.
| @@ -0,0 +1,688 @@ | |||
| /* https://github.com/sindresorhus/github-markdown-css */ | |||
|
|
|||
| @font-face { | |||
There was a problem hiding this comment.
This font-face is not used and should be removed.
| function setCustomTheme() { | ||
| _hideSettings(); | ||
|
|
||
| Dialogs.showModalDialog( |
There was a problem hiding this comment.
This dialog is not necessary. Selecting the 'Custom' theme should go directly to the file system open dialog.
| # Markdown Preview | ||
|
|
||
| A [Brackets](https://github.com/adobe/brackets) extension that provides a live preview of markdown documents. | ||
| Forked from <https://github.com/gruehle/MarkdownPreview> |
| } | ||
|
|
||
| if (fi.length === 1) { | ||
| _prefs.set("theme", "custom"); |
There was a problem hiding this comment.
Once a custom theme is set, there is no way to change it to a different theme (short of renaming the file to force a reset). There should be a way to switch to a different CSS file.
Here is one possible suggestion: keep the Custom menu item, but add a new menu item whenever a custom CSS file is selected. This way the theme menu is populated with all of the built-in themes, and all themes selected by the user. If you do this, the Custom menu item should have an ellipses at the end.
|
Thanks @gruehle, I'll review and update once I have some time. |
2 participants
Changelog: