add ability to sign commits with git-xargs#140
add ability to sign commits with git-xargs#140zack-is-cool wants to merge 4 commits intogruntwork-io:masterfrom
Conversation
|
@zack-is-cool I saw this PR was waiting on an approver and since I also need this feature I just fetched your repo/branch |
|
@gekitsuu try bumping up the logging level for more info. You can look at the debug logging I added. I've been using my fork since I made this PR to be able to sign commits for my org's security settings. |
|
@zack-is-cool I did that and realized that I hadn't checked out the branch correctly. I am able to run the command now, and it prompted me for my GPG key password. Even though I'm entering the passphrase correctly, I get |
|
@zack-is-cool Not sure I tagged you correctly in the last comment |
|
Not totally sure tbh, you can kinda see what's going on - specifically here it's calling gpg program with arguments |
|
@zack-is-cool I'm going to guess that you don't have a password on your GPG key. When I removed the passphrase from mine, then your branch signed the commit as expected, but it should handle taking a user through supplying the passphrase if they use one. |

Description
Closes #93.
This PR allows users to sign commits with git-xargs using a global signingkey in their git config.
see: https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key for more info on configuring git to use a signing key.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added ability to sign commits with git-xargs. This depends on the user's git config to be configured with a signing key. If not configured, it will default to not signing commits.
Migration Guide
N/A