fixes #109 - fix checkout existing branch#148
Closed
navrkald wants to merge 3 commits intogruntwork-io:masterfrom
Closed
fixes #109 - fix checkout existing branch#148navrkald wants to merge 3 commits intogruntwork-io:masterfrom
navrkald wants to merge 3 commits intogruntwork-io:masterfrom
Conversation
Author
|
Closing this PR in favour of #149 which is using Gruntwork compatible branch name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #109.
Original code did equivalent of following:
new code is properly checkouting remote branch if exists
Problem with original code is not only that's not convenient, but it's as well bugy, it's silently supposing that
<branch name>was created on top of default remote branch name plus it's supposing remote branch name wasn't changed in meanwhile until remote<branch name>was created. Ofc this conditions are often not met and thats the case when the bug #109 appears.TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Fixed #109 checkout remote branch locally if exists.
Migration Guide