Add SPIRV-Tools source directory to include paths for pass_manager.h#39
Draft
Add SPIRV-Tools source directory to include paths for pass_manager.h#39
Conversation
spirvgenerator.cc includes spirv-tools/libspirv.h which in Vulkan SDK 1.4.304.1 transitively includes internal headers like pass_manager.h. This fix adds the SPIRV-Tools source directory to the include paths when available. Co-authored-by: Duttenheim <6490176+Duttenheim@users.noreply.github.com>
… paths Co-authored-by: Duttenheim <6490176+Duttenheim@users.noreply.github.com>
Co-authored-by: Duttenheim <6490176+Duttenheim@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Identify file that includes pass_manager.h
Add SPIRV-Tools source directory to include paths for pass_manager.h
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build fails on Vulkan SDK 1.4.304.1 because
spirvgenerator.ccincludesspirv-tools/libspirv.h, which transitively includespass_manager.h— an internal header insource/opt/not exposed in the public API.Changes
$VULKAN_SDK/sourcetoSPIRV-Tools-opttarget'sINTERFACE_INCLUDE_DIRECTORIESincode/compiler/CMakeLists.txtThis works around a packaging issue in the SDK where internal implementation headers leak through the public API.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.