Fix e2e hook starvation under describe.concurrent#49
Merged
gtbuchanan merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
Replace crossSpawn.sync with async spawn in runCommand so the event loop is free between awaits. This prevents beforeEach hooks from timing out when concurrent tests spawn CLI processes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gtbuchanan
force-pushed
the
fix/e2e-starvation
branch
from
b692647 to
e903c58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crossSpawn.syncwith async spawn inrunCommandso the event loop is free between awaits, preventingbeforeEachhook timeouts in concurrent e2e testsCloses #47
Test plan
pnpm checkpasses (typecheck + lint + fast tests)pnpm buildpasses (includes all e2e tests — eslint-config, cli, vitest-config, tsconfig, markdownlint-config)🤖 Generated with Claude Code