fix(#229): stub sandbox.EnsureAvailable in TestRunAgent tests

[fullsend-ai-coder]

Summary

• Make the sandbox availability check injectable via a package-level sandboxEnsureAvailable variable (defaulting to sandbox.EnsureAvailable)
• The five TestRunAgent_* harness-loading tests now call stubSandboxCheck(t) to override this variable, making them hermetic regardless of whether openshell is installed on the host
• Follows the existing pattern used by heartbeatInterval and oidcRefreshInterval for test-time dependency injection

Closes #229

Test plan

• go vet ./internal/cli/... passes
• All five affected tests pass: TestRunAgent_HarnessLoadPipeline, TestRunAgent_YMLFallback, TestRunAgent_HarnessLoadWithOrgConfig, TestRunAgent_MalformedOrgConfig, TestRunAgent_WithURLBase
• Full go test ./internal/cli/... passes (4 pre-existing failures in fetchserver_test.go unrelated to this change)
• Secret scan passed

🤖 Generated with Claude Code

[github-actions]

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

[fullsend-ai-review]

🤖 Finished Review · ❌ Failure · Started 12:56 PM UTC · Completed 12:57 PM UTC
Commit: c776c24 · View workflow run →

[guyoron1]

/fs-review

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 4:02 PM UTC · Completed 4:13 PM UTC
Commit: d8e3df7 · View workflow run →

[fullsend-ai-review]

Review

Findings

Medium

• [commit-message-prefix] — The PR title uses fix(#229) but per COMMITS.md, fix is reserved for "Bug fix visible to users." This change modifies test infrastructure — the production code change (adding the sandboxEnsureAvailable variable) exists solely to enable test stubbing with no change to user-visible behavior. The correct prefix is test(#229). COMMITS.md states: "When reviewing PRs, check that commit messages and PR titles use the correct type prefix. Flag violations as a required change — they are not cosmetic."
  Remediation: Change the PR title to test(#229): stub sandbox.EnsureAvailable in TestRunAgent tests.

---

Labels: PR modifies sandbox availability check stubbing in internal/cli

[guyoron1]

/fs-fix

[fullsend-ai-coder]

🤖 Finished Fix · ✅ Success · Started 5:44 PM UTC · Completed 5:51 PM UTC
Commit: d8e3df7 · View workflow run →

[fullsend-ai-coder]

🔧 Fix agent — iteration 1 (human-triggered)

The review agent's single finding (commit-message-prefix) is correct: this is a test infrastructure change, not a user-visible bug fix, so the PR title should use test(#229) instead of fix(#229). No code changes are needed — the fix is a PR title update that must be done by a maintainer.

Fixed (1):

1. commit-message-prefix: PR title uses fix([RTK+Ponytail] TestRunAgent_* tests hang when openshell is installed #229) but should use test([RTK+Ponytail] TestRunAgent_* tests hang when openshell is installed #229): Verified the finding is correct per COMMITS.md: fix is for user-visible bug fixes, but this PR modifies test infrastructure only (adds sandboxEnsureAvailable injection variable and stubSandboxCheck helper). The correct prefix is test([RTK+Ponytail] TestRunAgent_* tests hang when openshell is installed #229). The remediation requires changing the PR title to 'test([RTK+Ponytail] TestRunAgent_* tests hang when openshell is installed #229): stub sandbox.EnsureAvailable in TestRunAgent tests', which is a PR metadata mutation outside the fix agent's scope. A maintainer should update the PR title.

Tests: passed

_{Updated by fullsend fix agent}